SpotBugs Report

Project Information

Project: ActiveMQ :: Openwire Legacy Support

SpotBugs version: 4.8.3

Code analyzed:



Metrics

21071 lines of code analyzed, in 439 classes, in 7 packages.

Metric Total Density*
High Priority Warnings 0.00
Medium Priority Warnings 32 1.52
Total Warnings 32 1.52

(* Defects per Thousand lines of non-commenting source statements)



Contents

Summary

Warning Type Number
Malicious code vulnerability Warnings 7
Dodgy code Warnings 25
Total 32

Warnings

Click on a warning row to see full context information.

Malicious code vulnerability Warnings

Code Warning
MS Public static org.apache.activemq.openwire.v2.MarshallerFactory.createMarshallerMap(OpenWireFormat) may expose internal representation by returning MarshallerFactory.MARSHALLER
MS Public static org.apache.activemq.openwire.v3.MarshallerFactory.createMarshallerMap(OpenWireFormat) may expose internal representation by returning MarshallerFactory.MARSHALLER
MS Public static org.apache.activemq.openwire.v4.MarshallerFactory.createMarshallerMap(OpenWireFormat) may expose internal representation by returning MarshallerFactory.marshaller
MS Public static org.apache.activemq.openwire.v5.MarshallerFactory.createMarshallerMap(OpenWireFormat) may expose internal representation by returning MarshallerFactory.marshaller
MS Public static org.apache.activemq.openwire.v6.MarshallerFactory.createMarshallerMap(OpenWireFormat) may expose internal representation by returning MarshallerFactory.marshaller
MS Public static org.apache.activemq.openwire.v7.MarshallerFactory.createMarshallerMap(OpenWireFormat) may expose internal representation by returning MarshallerFactory.marshaller
MS Public static org.apache.activemq.openwire.v8.MarshallerFactory.createMarshallerMap(OpenWireFormat) may expose internal representation by returning MarshallerFactory.marshaller

Dodgy code Warnings

Code Warning
DLS Dead store to info in org.apache.activemq.openwire.v2.ConnectionControlMarshaller.tightMarshal2(OpenWireFormat, Object, DataOutput, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v2.IntegerResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v2.ReplayCommandMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v2.ResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v3.ConnectionControlMarshaller.tightMarshal2(OpenWireFormat, Object, DataOutput, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v3.IntegerResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v3.ReplayCommandMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v3.ResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v4.ConnectionControlMarshaller.tightMarshal2(OpenWireFormat, Object, DataOutput, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v4.IntegerResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v4.ReplayCommandMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v4.ResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v5.ConnectionControlMarshaller.tightMarshal2(OpenWireFormat, Object, DataOutput, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v5.IntegerResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v5.ReplayCommandMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v5.ResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v6.IntegerResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v6.ReplayCommandMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v6.ResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v7.IntegerResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v7.ReplayCommandMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v7.ResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v8.IntegerResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v8.ReplayCommandMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)
DLS Dead store to info in org.apache.activemq.openwire.v8.ResponseMarshaller.tightMarshal1(OpenWireFormat, Object, BooleanStream)

Details

DLS_DEAD_LOCAL_STORE: Dead store to local variable

This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.

Note that Sun's javac compiler often generates dead stores for final local variables. Because SpotBugs is a bytecode-based tool, there is no easy way to eliminate these false positives.

MS_EXPOSE_REP: Public static method may expose internal representation by returning a mutable object or array

A public static method returns a reference to a mutable object or an array that is part of the static state of the class. Any code that calls this method can freely modify the underlying array. One fix is to return a copy of the array.